API Changes

no api changes detected

This PR fixes a critical flaw in the release.yml workflow where essential CI jobs were being skipped on push and tag events. The root cause was the goreleaser job's dependency on dep-guard, which is configured to run only on pull_request events. This caused dep-guard to be skipped on push, leading to a chain reaction that skipped goreleaser and all of its downstream test and build jobs.

The fix decouples goreleaser from dep-guard in the main execution path. To preserve the dependency check for pull requests, the dep-guard job is now a dependency of the aggregator job, which runs only on pull requests. Additionally, the if conditions on several downstream jobs have been strengthened to ensure they only run if their dependencies have succeeded, making the workflow more robust.

Files Changed Analysis

• .github/workflows/release.yml: The sole file modified. The changes involve adjusting job dependencies and conditional logic to ensure the CI pipeline executes correctly for both push and pull_request events.

Architecture & Impact Assessment

• What this PR accomplishes: It ensures that the full suite of CI tests and builds runs on push events to release branches, preventing untested code from being deployed.

• Key technical changes introduced:

  1. The goreleaser job no longer needs: [dep-guard].
  2. The aggregator job now includes dep-guard in its needs list, preserving the dependency check for pull requests.
  3. Downstream jobs now have more explicit if conditions (e.g., !cancelled() && needs.goreleaser.result == 'success') to prevent execution when upstream jobs fail or are skipped.

• Affected system components: The change is strictly limited to the GitHub Actions CI/CD pipeline defined in release.yml. No application code is altered.

• Workflow Visualization:

  Before (push event):

graph TD
A[dep-guard] --|"skipped (not a PR)"|--> B[goreleaser]
B --|"transitively skipped"|--> C[test-controller-api]
B --|"transitively skipped"|--> D[...other jobs]

  **After (`push` event):**
  ```mermaid
graph TD
    subgraph "Main Workflow (runs on push)"
      A[goreleaser] --> C[test-controller-api]
      A --> D[...other jobs]
    end

    subgraph PR-only Gate
      B[dep-guard] --|runs only on PR|--> E[aggregator]
    end

Scope Discovery & Context Expansion

This change is highly targeted, modifying only the dependency logic within a single workflow file. The broader impact is restoring the reliability of the entire continuous integration process for release branches. By fixing the transitive skip issue, it ensures that all jobs dependent on goreleaser (such as test-controller-api, sbom, release-tests) are executed as intended on every push, safeguarding the release process.

Powered by Visor from Probelabs

Last updated: 2026-04-17T08:57:32.265Z | Triggered by: pr_updated | Commit: a28630f

💡 TIP: You can chat with Visor using /visor ask <your question>

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.

✅ Quality Check Passed

No quality issues found – changes LGTM.

Powered by Visor from Probelabs

Last updated: 2026-04-17T08:57:25.389Z | Triggered by: pr_updated | Commit: a28630f

💡 TIP: You can chat with Visor using /visor ask <your question>

🚨 Jira Linter Failed

Commit: a28630f
Failed at: 2026-04-17 08:55:49 UTC

The Jira linter failed to validate your PR. Please check the error details below:

failed to validate branch and PR title rules: branch name 'fix/dep-guard-skip-release-5.12.1' must contain a valid Jira ticket ID (e.g., ABC-123)

Next Steps

• Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
• Verify your PR title matches the branch's Jira ticket ID
• Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.